[Fix] Fix error when data_root option in val_cfg or test_cfg are set as None
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 75.67% 75.33% -0.35%
==========================================
Files 107 108 +1
Lines 6446 6490 +44
Branches 1133 1140 +7
==========================================
+ Hits 4878 4889 +11
- Misses 1262 1295 +33
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nbei
reviewed
May 24, 2021
tools/evaluation.py
Outdated
| dataset = build_dataset(cfg.data.val) | ||
| else: | ||
| elif cfg.data.get('train', None) and \ |
There was a problem hiding this comment.
Here, I may suggest that we can just use cfg.data.get('train', None). Because we assume that the train part should work well once it has been added.
LeoXing1996
pushed a commit
that referenced
this pull request
Jul 16, 2022
[Fix] Fix error when `data_root` option in val_cfg or test_cfg are set as None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use if-else to judge whether config is valid, and ignore configs whose
data_rootisNone.