Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix duplicate init_weights call in ViT init function. #373

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented Jul 26, 2021

Remove duplicate init_weights call in ViT.
This will cause init_weights to fail in latest mmcv==1.3.10

@mzr1996 mzr1996 requested a review from Ezra-Yu July 26, 2021 08:36
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #373 (f0d0b4f) into master (474c55d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   76.02%   76.01%   -0.01%     
==========================================
  Files          96       96              
  Lines        5113     5112       -1     
  Branches      849      849              
==========================================
- Hits         3887     3886       -1     
  Misses       1108     1108              
  Partials      118      118              
Flag Coverage Δ
unittests 76.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/vision_transformer.py 76.47% <ø> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474c55d...f0d0b4f. Read the comment docs.

Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mzr1996 mzr1996 merged commit 899047a into open-mmlab:master Jul 26, 2021
@mzr1996 mzr1996 deleted the fix-vit-dup-init branch July 28, 2021 03:34
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants