Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update install tutorials. #854

Merged
merged 4 commits into from
Jun 1, 2022
Merged

[Docs] Update install tutorials. #854

merged 4 commits into from
Jun 1, 2022

Conversation

mzr1996
Copy link
Member

@mzr1996 mzr1996 commented May 25, 2022

As the title, refers to open-mmlab/mmdetection#7897

@mzr1996 mzr1996 requested a review from Ezra-Yu May 25, 2022 11:27
@codecov
Copy link

codecov bot commented May 25, 2022 •
edited
Loading

Codecov Report

Merging #854 (2cb8355) into dev (877ea30) will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #854      +/-   ##
==========================================
- Coverage   86.80%   86.59%   -0.21%     
==========================================
  Files         130      130              
  Lines        8571     8528      -43     
  Branches     1478     1478              
==========================================
- Hits         7440     7385      -55     
- Misses        909      915       +6     
- Partials      222      228       +6
Flag Coverage Δ
unittests 86.59% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/models/backbones/densenet.py 95.08% <ø> (-0.04%) ⬇️
mmcls/models/backbones/van.py 96.83% <ø> (ø)
mmcls/models/utils/helpers.py 79.16% <0.00%> (-20.84%) ⬇️
mmcls/datasets/builder.py 82.43% <0.00%> (-5.41%) ⬇️
mmcls/utils/setup_env.py 95.45% <0.00%> (-4.55%) ⬇️
mmcls/models/heads/base_head.py 85.71% <0.00%> (-1.79%) ⬇️
mmcls/models/backbones/convmixer.py 96.72% <0.00%> (-1.64%) ⬇️
mmcls/models/classifiers/base.py 76.31% <0.00%> (-1.19%) ⬇️
mmcls/models/backbones/base_backbone.py 88.88% <0.00%> (-1.12%) ⬇️
mmcls/core/visualization/image.py 86.32% <0.00%> (-0.86%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877ea30...2cb8355. Read the comment docs.

Ezra-Yu
Ezra-Yu reviewed May 25, 2022
View reviewed changes
demo/image_demo.py Outdated Show resolved Hide resolved
docs/zh_CN/compatibility.md Outdated Show resolved Hide resolved
Ezra-Yu
Ezra-Yu approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@Ezra-Yu Ezra-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mzr1996 mzr1996 merged commit 3e198e6 into open-mmlab:dev Jun 1, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
@mzr1996
[Docs] Update install tutorials. (open-mmlab#854)
c583cba 
* [Docs] Update install tutorials.

* [Docs] Improve dataset docs

* Add option to show the results in demo.

* fix typo
@mzr1996 mzr1996 deleted the update-install branch December 7, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ezra-Yu Ezra-Yu Ezra-Yu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzr1996 @Ezra-Yu