Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix mmcv mmengine #242

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

sunnyxiaohu
Copy link
Contributor

@sunnyxiaohu sunnyxiaohu commented Aug 23, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Substitute training-related modules in mmcv because they have been re-implemented in mmengine

Modification

  1. Substitute mmcv.runner with mmengine.model, mmengine.runner and mmengine.dist
  2. Partially substitute mmcv.cnn with mmengine.model.utils
  3. Unify registry CONV_LAYERS and NORM_LAYERS with MODELS
  4. Partially substitute mmcv.utils with mmengine.utils

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sunnyxiaohu sunnyxiaohu changed the title align_with_mmcv_and_mmengine [fix] fix_mmcv_mmengine Aug 23, 2022
@sunnyxiaohu sunnyxiaohu changed the title [fix] fix_mmcv_mmengine [fix] fix mmcv mmengine Aug 23, 2022
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #242 (211208c) into dev-1.x (57aec1f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           dev-1.x    #242      +/-   ##
==========================================
- Coverage     0.48%   0.44%   -0.05%     
==========================================
  Files          144     161      +17     
  Lines         5943    6506     +563     
  Branches       959    1064     +105     
==========================================
  Hits            29      29              
- Misses        5909    6472     +563     
  Partials         5       5              
Flag Coverage Δ
unittests 0.44% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...thms/distill/configurable/datafree_distillation.py 0.00% <0.00%> (ø)
...hms/distill/configurable/single_teacher_distill.py 0.00% <0.00%> (ø)
...ls/architectures/backbones/searchable_mobilenet.py 0.00% <0.00%> (ø)
...rchitectures/backbones/searchable_shufflenet_v2.py 0.00% <0.00%> (ø)
.../models/architectures/connectors/base_connector.py 0.00% <0.00%> (ø)
...ls/architectures/dynamic_op/bricks/dynamic_conv.py 0.00% <ø> (ø)
...ls/architectures/dynamic_op/bricks/dynamic_norm.py 0.00% <0.00%> (ø)
.../models/architectures/generators/base_generator.py 0.00% <0.00%> (ø)
...or/models/architectures/heads/darts_subnet_head.py 0.00% <0.00%> (ø)
mmrazor/models/losses/dafl_loss.py 0.00% <0.00%> (ø)
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gaoyang07 gaoyang07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it in .dev_scripts/ & tools/

@sunnyxiaohu
Copy link
Contributor Author

fix it in .dev_scripts/ & tools/
Done

@sunnyxiaohu sunnyxiaohu merged commit ba71abf into open-mmlab:dev-1.x Aug 24, 2022
humu789 pushed a commit to humu789/mmrazor that referenced this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants