Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]Upgrade isort in pre-commit hook #70

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

HIT-cwh
Copy link
Collaborator

@HIT-cwh HIT-cwh commented Feb 8, 2022

Modification

  1. Remove seed-isort-config in pre-commit hook
  2. Upgrade isort to v5.10.1 (latest version)
  3. Replace known_standard_library with extra_standard_library

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #70 (cf5de0d) into master (0dd407a) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   56.58%   56.51%   -0.07%     
==========================================
  Files          83       83              
  Lines        2932     2932              
  Branches      540      540              
==========================================
- Hits         1659     1657       -2     
- Misses       1197     1198       +1     
- Partials       76       77       +1     
Flag Coverage Δ
unittests 56.51% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmrazor/models/mutators/one_shot_mutator.py 92.59% <0.00%> (-3.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd407a...cf5de0d. Read the comment docs.

@pppppM pppppM merged commit 4121e58 into open-mmlab:master Feb 10, 2022
humu789 pushed a commit that referenced this pull request Feb 16, 2022
* Update README according to OpenMMLab standard.

* [Refactor]Deprecate the support for ``python setup.py test`` (#60)

* Deprecate the support for ``python setup.py test``

* Update requirements

* Upgrade isort in pre-commit hook (#70)

* Update README according to OpenMMLab standard.

* modify uppercase and lowercase

Co-authored-by: whcao <41630003+HIT-cwh@users.noreply.github.com>
pppppM pushed a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022
pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022
* Update README according to OpenMMLab standard.

* [Refactor]Deprecate the support for ``python setup.py test`` (open-mmlab#60)

* Deprecate the support for ``python setup.py test``

* Update requirements

* Upgrade isort in pre-commit hook (open-mmlab#70)

* Update README according to OpenMMLab standard.

* modify uppercase and lowercase

Co-authored-by: whcao <41630003+HIT-cwh@users.noreply.github.com>
pppppM pushed a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022
pppppM added a commit to pppppM/mmrazor that referenced this pull request Jul 15, 2022
* Update README according to OpenMMLab standard.

* [Refactor]Deprecate the support for ``python setup.py test`` (open-mmlab#60)

* Deprecate the support for ``python setup.py test``

* Update requirements

* Upgrade isort in pre-commit hook (open-mmlab#70)

* Update README according to OpenMMLab standard.

* modify uppercase and lowercase

Co-authored-by: whcao <41630003+HIT-cwh@users.noreply.github.com>
@HIT-cwh HIT-cwh deleted the isort-upgrade branch October 22, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants