fixed a couple of issues that made the notebook not work in colab #1460
Conversation
i fixed a couple of issues that made the notebook not work in colab 1. it downloaded incompatible versions of pytorch and cuda + the conda command doesnt do anything in colab since there is no conda in colab idk w y wanna do about that - The commit of 2 days ago only changes the conda command version and not the pip command which is used while isntaling mcvv 2. /demo.png doesnt exist in colab so i added a wget to download some cityscapes photo from the internet and run inference on that photo 3. i think it would be optimal to have 2 notebooks. 1 for running locally when cloning your git branch and one to run in google colab.
|
|
There was a problem hiding this comment.
Many thanks for your contribution and please sign CLA first.
After our discussion, we think keep 2 notebooks you suggested is a good idea, and this notebook is just for users running locally, so it might only fix mmcv installation in this PR, and keep the other as it is. thanks again
demo/MMSegmentation_Tutorial.ipynb
Outdated
| "config_file = '../mmsegmentation/configs/pspnet/pspnet_r50-d8_512x1024_40k_cityscapes.py'\n", | ||
| "checkpoint_file = '../mmsegmentation/checkpoints/pspnet_r50-d8_512x1024_40k_cityscapes_20200605_003338-2966598c.pth'\n" |
There was a problem hiding this comment.
we usually assumed users run this notebook locally, so we would like to keep the original file path.
There was a problem hiding this comment.
Many thanks for your contribution and please sign CLA first.
After our discussion, we think
keep 2 notebooksyou suggested is a good idea, and this notebook is just for users running locally, so it might only fix mmcv installation in this PR, and keep the other as it is. thanks again
yeah i agree, 2 notebooks will work best since theyre designed to run in 2 completely different enviroments, i have signed the cla
yes just remember for the colab version to use the config file and checkpoint file paths i suggested, those worked for me
…pen-mmlab#1460) * fixed a couple of issues that made the notebook not work in colab i fixed a couple of issues that made the notebook not work in colab 1. it downloaded incompatible versions of pytorch and cuda + the conda command doesnt do anything in colab since there is no conda in colab idk w y wanna do about that - The commit of 2 days ago only changes the conda command version and not the pip command which is used while isntaling mcvv 2. /demo.png doesnt exist in colab so i added a wget to download some cityscapes photo from the internet and run inference on that photo 3. i think it would be optimal to have 2 notebooks. 1 for running locally when cloning your git branch and one to run in google colab. * Update demo/MMSegmentation_Tutorial.ipynb * Update demo/MMSegmentation_Tutorial.ipynb * Update demo/MMSegmentation_Tutorial.ipynb * Update demo/MMSegmentation_Tutorial.ipynb * Update demo/MMSegmentation_Tutorial.ipynb Co-authored-by: Miao Zheng <76149310+MeowZheng@users.noreply.github.com>
i fixed a couple of issues that made the notebook not work in colab
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
i want to create a notebook that is instantly runnable in google colab - the previous setup only work if u git clone ur branch
Modification
i changed like 5 lines of code
BC-breaking (Optional)
i dont think this will break anything
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist