Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix mdformat version to support python3.6 and remove ruby install #1672

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • Fix mdformat version to support python3.6 and refine documentation.
  • Remove ruby from CI

ref: open-mmlab/mmcv#2014

Modification

  1. .github/workflows/lint.yml
  2. .pre-commit-config.yaml

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #1672 (1ed0ae3) into master (46326f6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.02%     
==========================================
  Files         142      142              
  Lines        8477     8486       +9     
  Branches     1428     1432       +4     
==========================================
+ Hits         7651     7658       +7     
- Misses        586      588       +2     
  Partials      240      240              
Flag Coverage Δ
unittests 90.24% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/apis/inference.py 61.66% <0.00%> (-2.13%) ⬇️
mmseg/models/backbones/vit.py 90.85% <0.00%> (-0.06%) ⬇️
mmseg/datasets/pipelines/test_time_aug.py 96.55% <0.00%> (+0.25%) ⬆️
mmseg/models/segmentors/encoder_decoder.py 88.66% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46326f6...1ed0ae3. Read the comment docs.

@MeowZheng MeowZheng merged commit a6d6c44 into open-mmlab:master Jun 16, 2022
@MeowZheng MeowZheng deleted the remove-ruby branch June 16, 2022 05:24
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
…all (open-mmlab#1672)

* [Docs] Fix mdformat version to support python3.6 and remove ruby install

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants