Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support SegNeXt in MMSegmentation 2.0 #2654

Merged
merged 9 commits into from
Mar 16, 2023

Conversation

MengzhangLI
Copy link
Contributor

Motivation

Support SegNeXt in MMSeg 1.x branch.

0.x PR: #2600

WIP: README.md needs to be refined...

@MengzhangLI MengzhangLI added WIP Work in process Algorithm Improvement or addition of new algorithm model 1.x Related issue of 1.x version labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Patch coverage: 92.60% and project coverage change: +0.26 🎉

Comparison is base (dd47cef) 83.44% compared to head (d42a4e8) 83.71%.

❗ Current head d42a4e8 differs from pull request most recent head 83da311. Consider uploading reports for the commit 83da311 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2654      +/-   ##
===========================================
+ Coverage    83.44%   83.71%   +0.26%     
===========================================
  Files          154      156       +2     
  Lines         9075     9332     +257     
  Branches      1345     1367      +22     
===========================================
+ Hits          7573     7812     +239     
- Misses        1265     1276      +11     
- Partials       237      244       +7     
Flag Coverage Δ
unittests 83.71% <92.60%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/decode_heads/ham_head.py 89.89% <89.89%> (ø)
mmseg/models/backbones/mscan.py 94.23% <94.23%> (ø)
mmseg/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmseg/models/decode_heads/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xiexinch xiexinch self-requested a review February 28, 2023 04:42
@MengzhangLI MengzhangLI removed the WIP Work in process label Mar 1, 2023
@MengzhangLI MengzhangLI changed the title [WIP][Feature] Support SegNeXt in MMSegmentation 2.0 [Feature] Support SegNeXt in MMSegmentation 2.0 Mar 1, 2023
.pre-commit-config.yaml Outdated Show resolved Hide resolved
configs/segnext/segnext.yml Outdated Show resolved Hide resolved
configs/segnext/README.md Outdated Show resolved Hide resolved
configs/segnext/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@MeowZheng MeowZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please solve the conflict.


```python
def main():
from mmseg.apis import set_random_seed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_random_seed has been removed

@MeowZheng MeowZheng merged commit ff8d971 into open-mmlab:dev-1.x Mar 16, 2023
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* fix AttnProcessor2_0

Fix use of AttnProcessor2_0 for cross attention with mask

* added scale_qk and out_bias flags

* fixed for xformers

* check if it has scale argument

* Update cross_attention.py

* check torch version

* fix sliced attn

* style

* set scale

* fix test

* fixed addedKV processor

* revert back AttnProcessor2_0

* if missing if

* fix inner_dim

---------

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
@anilantony
Copy link

anilantony commented Jun 2, 2023

Please help me to run SegNeXt in MMSegmentation 2.0 in colab...

nahidnazifi87 pushed a commit to nahidnazifi87/mmsegmentation_playground that referenced this pull request Apr 5, 2024
## Motivation

Support SegNeXt in MMSeg 1.x branch.

0.x PR: open-mmlab#2600

---------

Co-authored-by: xiexinch <xiexinch@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Related issue of 1.x version Algorithm Improvement or addition of new algorithm model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants