Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support (Experimental) #75

Merged
merged 17 commits into from
Aug 28, 2020
Merged

Windows Support (Experimental) #75

merged 17 commits into from
Aug 28, 2020

Conversation

johnzja
Copy link
Contributor

@johnzja johnzja commented Aug 19, 2020

Training & Testing supported under Windows.
READMEs updated.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #75 into master will decrease coverage by 0.07%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   82.04%   81.97%   -0.08%     
==========================================
  Files          76       76              
  Lines        3464     3467       +3     
  Branches      529      529              
==========================================
  Hits         2842     2842              
- Misses        519      522       +3     
  Partials      103      103              
Flag Coverage Δ
#unittests 81.97% <14.28%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/utils/collect_env.py 20.00% <0.00%> (-1.16%) ⬇️
mmseg/__init__.py 73.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2981245...0a09d71. Read the comment docs.

@johnzja johnzja requested a review from xvjiarui August 20, 2020 01:32
@johnzja
Copy link
Contributor Author

johnzja commented Aug 21, 2020

Problems with mmcv=1.1.0.

in os package under Windows.

```python
checkpoint_config = dict(create_symlink=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may consider update mmcv to disable create_symlink automatically on windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

docs/install.md Outdated
```

b. Install PyTorch and torchvision following the [official instructions](https://pytorch.org/).
Here we use PyTorch 1.5.0 and CUDA 10.1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use pytorch 1.6.0 for examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

johnzja and others added 3 commits August 23, 2020 17:11
* Fix fast_scnn resize problems

* Fix fast_scnn resize problems 1

* Fix fast_scnn resize problems 2

* test for pascal voc
@johnzja johnzja requested a review from hellock August 24, 2020 10:58
@johnzja
Copy link
Contributor Author

johnzja commented Aug 24, 2020

I'll use "merge" instead of "rebase" when i need to keep my branch updated with open-mmlab/mmsegmentation.

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
johnzja and others added 2 commits August 27, 2020 16:35
Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
@xvjiarui xvjiarui merged commit 597b8a6 into open-mmlab:master Aug 28, 2020
@johnzja johnzja deleted the win branch August 28, 2020 06:38
@sshuair
Copy link
Contributor

sshuair commented Sep 2, 2021

@johnzja Have you test it on multi-gpu with DDP training?

bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* Windows basic support

* getting_started updated for Windows.

* add experimental

* install.md restructured to seperate Windows & Linux.

* fix problems in install.md

* fix mmcv version problem.

* Fix fastscnn resize problems. (open-mmlab#82)

* Fix fast_scnn resize problems

* Fix fast_scnn resize problems 1

* Fix fast_scnn resize problems 2

* test for pascal voc

* [Doc] Add annotaion format note (open-mmlab#77)

* update pytorch version to 1.6.0 in install.md

* del fastscnn_pascal config

* del create_symlink=True

* Merge instructions for Linux & Windows

* mmcv version updated

* redundant newline deleted

* Update docs/install.md

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>

* Update docs/install.md

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>

Co-authored-by: Jerry Jiarui XU <xvjiarui0826@gmail.com>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants