Windows Die and Module (and NumaNodeEx) relationships #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoglin
force-pushed
the
windows-new-levels
branch
3 times, most recently
from
fefc02e to
9522cbf
Compare
bgoglin
force-pushed
the
windows-new-levels
branch
from
9522cbf to
a574fde
Compare
bgoglin
force-pushed
the
windows-new-levels
branch
from
a574fde to
0153e8a
Compare
|
As of 2023/04, WS22 exposes returns Die/Module info when explicitly requested (Windows 11 does the same when it doesn't crash for unknown reasons). When requesting All relations on a machine without multiple Dies or Modules, Processor/Core/Group/Numa are returned as usual, but no Die/Module. If that's the desired behavior, that means we wouldn't have to manually ignore useless Die/Module objects, good. |
|
Requested some clarification from Microsoft at MicrosoftDocs/feedback#3917 |
bgoglin
force-pushed
the
windows-new-levels
branch
from
2eb2d0b to
6eb2d69
Compare
Starting with "Windows Server 2022 (21H2, build 20348)", new relations were added for Die, Module and NumaNodeEx. NumaNodeEx is only for requesting NUMA info in scalable format (contrary to the old "Numa"), which we already get through "All". "Die" and "Module" look like what Intel added in x86 CPUID (already supported in the x86 backend) but it's missing the "Tile" level for some reason (never used afaik). RelationProcessorDie uses our existing DIE object. RelationProcessorModule uses GROUP with subkind "Module" just like x86 did. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin
force-pushed
the
windows-new-levels
branch
from
6eb2d69 to
4ae5aa7
Compare
bgoglin
changed the title
bgoglin
added a commit
that referenced
this pull request
Aug 23, 2024
The Linux backend ignored Dies that are identical to packages because the kernel may expose that even if the hardware does not support Dies. Windows might do the same (see #480 but no reply from Microsoft yet). Move the filtering to the core and only apply it if all Dies are identical to their Package. Implemented by forcing KEEP_STRUCTURE filtering only between Dies and Packages. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin
added a commit
that referenced
this pull request
Aug 25, 2024
The Linux backend ignored Dies that are identical to packages because the kernel may expose that even if the hardware does not support Dies. Windows might do the same (see #480 but no reply from Microsoft yet). Move the filtering to the core and only apply it if all Dies are identical to their Package. Implemented by forcing KEEP_STRUCTURE filtering only between Dies and Packages. Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr> (cherry picked from commit 0b0f5fa)
bgoglin
added a commit
that referenced
this pull request
Sep 6, 2024
procInfo[i] is garbage, use procInfo to get relation information when setting group kinds. Thanks to this fix, I now confirm that Windows 11 is able to report "Module" objects, at least on Intel MeteorLake CPUs. hwloc exposes them a "Module" groups which are usually merged into L2 caches. Ref #480 By the way, remove an obsolete comment nearby Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin
added a commit
that referenced
this pull request
Sep 11, 2024
procInfo[i] is garbage, use procInfo to get relation information when setting group kinds. Thanks to this fix, I now confirm that Windows 11 is able to report "Module" objects, at least on Intel MeteorLake CPUs. hwloc exposes them a "Module" groups which are usually merged into L2 caches. Ref #480 By the way, remove an obsolete comment nearby Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr> (cherry picked from commit 1dc4faf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some future Windows release (TBD) will expose "Die" and "Module" information as well as NUMA nodes spanning mulitple processor groups. Bits are appearing in the onlie doc, we don't know all the details yet, and we don't have a way to test yet.