sessions: add missing errhandler funcs #10442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These missing functions are a blocker for v5.0; we can't claim sessions support without them. |
|
bot:ompi:retest |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
somehow managed to not get into the original sessions pr. also do some cleanup of the use mpi_f08 profiling functions. Related to open-mpi#10388 Related to open-mpi#9097 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
fix_for_issue_10388
branch
from
b030970 to
e5c3795
Compare
jjhursey
approved these changes
Jul 5, 2022
| @@ -513,7 +513,6 @@ typedef int (MPI_Type_delete_attr_function)(MPI_Datatype, int, | |||
| typedef int (MPI_Win_copy_attr_function)(MPI_Win, int, void *, | |||
| void *, void *, int *); | |||
| typedef int (MPI_Win_delete_attr_function)(MPI_Win, int, void *, void *); | |||
| typedef int (MPI_Session_delete_attr_function)(MPI_Session, int, void *, void *); | |||
There was a problem hiding this comment.
This change already came in #10499 - maybe the branch needs to be rebased?
| /* Ditch the old errhandler, and decrement its refcount. */ | ||
| tmp = session->error_handler; | ||
| session->error_handler = errhandler; | ||
| OBJ_RELEASE(tmp); |
There was a problem hiding this comment.
Do you need to check if this is a predefined error handler before releasing it? The logic in this function follows MPI_Comm_set_errhandler so it should be ok. But worth asking the question.
There was a problem hiding this comment.
good point. I think we may want protection in the mPI_Errhandler object destructor to catch this. But this can be for another PR.
|
thanks @jjhursey . doesn't look like there's a conflict so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
somehow managed to not get into the original sessions pr.
also do some cleanup of the use mpi_f08 profiling functions.
Related to #10388
Related to #9097
Signed-off-by: Howard Pritchard howardp@lanl.gov