Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A variety of docs updates #10793

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented Sep 12, 2022

  • Typo fixes
  • Add :ref: links to man pages (mostly mpirun and ompi_info)
  • Add notes for contributors about PR'ing to main first and then cherry-picking to release branches later. Thanks to @jolivain suggesting that we add this policy to the docs.
  • Include contributor suggestion to submit fixes to the docs.
  • Renamed Developers -> Git to "GitHub, Git, and related topics".
    Added info about:
    • Git commits and a reference to the contributors declaration (in contributors.rst)
    • Branching scheme
    • Details about PR to main first and cherry-picking to release branches
    • A few words about Github PR CI / MTT
  • Added information about running Sphinx, and how to view the Sphinx docs locally
  • Added notes about how to view man pages locally
  • Added a placeholder oshrun.1 man page (it just refers to mpirun.1)
  • Per v5.0.x: docs updates #10772 (comment), discuss PMIx and PRRTE MCA
  • Mention Perl and Python as tools required by Open MPI developers
  • Expanded on some "advice for packagers" from the "required support dependencies" section, and moved it to its own section:
    • Don't use Open MPI's bundled sub-packages (Libevent, Hwloc, PMIx, PRTE)
    • Discussion of components: included in project libraries vs. DSOs
  • Add short "prerequisites" section for running MPI apps

@jsquyres
Copy link
Member Author

@awlauria @jjhursey Could you guys especially check the PMIx / PRRTE tables I created on https://ompi--10793.org.readthedocs.build/en/10793/running-apps/tuning.html? Search for "PMIx" on that page to find all the text I added about this.

@rhc54
Copy link
Contributor

rhc54 commented Sep 12, 2022

Errr...just glanced at it and there are a number of errors (e.g., OMPI MCA params on the cmd line are not --mca, but --omca, the default user-level PMIx param file is in the .pmix subdirectory, not .openpmix, etc.). Not sure how you want me to identify those for you?

@jsquyres
Copy link
Member Author

@rhc54 Great, thanks! If you could mark up the PR here, that would be great: https://github.com/open-mpi/ompi/pull/10793/files#diff-c0a15e3d161d877e29843a3d0ef2cddc0a239a7167c837082fcf519f39a8b678

@jsquyres
Copy link
Member Author

@rhc54 I note that passing MCA params on the mpirun command line does use --mca, however. Is this part of the OMPI schitzo component? This is from an OMPI main build:

$ mpirun --help |& grep mca
   --mca <arg0> <arg1>               Pass context-specific MCA parameters; they are considered global if
                                     --gmca is not used and only one context is specified (arg0 is the
   --pmixmca <arg0> <arg1>           Pass context-specific PMIx MCA parameters; they are considered global if
   --prtemca <arg0> <arg1>           Pass context-specific PRTE MCA parameters to the DVM
...

@rhc54
Copy link
Contributor

rhc54 commented Sep 12, 2022

That is an error in your help text file. The --mca is a generic parameter option where you don't know which project the param belongs to and you want PRRTE to make a "best effort" guess on your behalf. If we guess wrong, it won't do anything. So you are better off using the project-specific --omca option unless you really don't know what project the param belongs to.

@jsquyres jsquyres force-pushed the pr/more-random-docs-updates branch from 915632e to b24022c Compare September 19, 2022 20:37
@jsquyres
Copy link
Member Author

@rhc54 @bwbarrett and I met last week and discussed Ralph's comments. He's right: there's a technical challenge on the PRTE side to figure out which framework a given MCA param is destined for. We think we have a solution, and are working on it (independent of this PR).

I just pushed a few more text updates to this PR.

@jsquyres jsquyres force-pushed the pr/more-random-docs-updates branch from b24022c to 75f53fd Compare September 19, 2022 20:44
@jsquyres
Copy link
Member Author

bot:aws:recheck

docs/building-apps/quickstart.rst Outdated Show resolved Hide resolved
@jsquyres jsquyres force-pushed the pr/more-random-docs-updates branch 2 times, most recently from 161f054 to bc9254a Compare September 20, 2022 19:35
@jsquyres
Copy link
Member Author

Per Slack discussion with @bwbarrett, also remove advice about using || and && with the test operator.

@awlauria
Copy link
Contributor

bot:ibm:retest

* Typo fixes
* Add :ref: links to man pages (mostly `mpirun` and `ompi_info`)
* Add notes for contributors about PR'ing to `main` first and then
  cherry-picking to release branches later.  Thanks to @jolivain
  suggesting that we add this policy to the docs.
* Include contributor suggestion to submit fixes to the docs.
* Renamed Developers -> Git to "GitHub, Git, and related topics".
  Added info about:
  * Git commits and a reference to the contributors
    declaration (in contributors.rst)
  * Branching scheme
  * Details about PR to main first and cherry-picking to release
    branches
  * A few words about Github PR CI / MTT
* Added information about running Sphinx, and how to view the Sphinx
  docs locally
* Added notes about how to view man pages locally
* Added a placeholder oshrun.1 man page (it just refers to mpirun.1)
* Per
  open-mpi#10772 (comment),
  discuss PMIx and PRRTE MCA
* Mention Perl and Python as tools required by Open MPI developers
* Expanded on some "advice for packagers" from the "required support
  dependencies" section, and moved it to its own section:
  * Don't use Open MPI's bundled sub-packages (Libevent, Hwloc, PMIx,
    PRTE)
  * Discussion of components: included in project libraries vs. DSOs
* Add short "prerequisites" section for running MPI apps

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres jsquyres force-pushed the pr/more-random-docs-updates branch from bc9254a to 061f908 Compare September 21, 2022 13:38
@jsquyres
Copy link
Member Author

Force pushed some minor corrections:

  • Fixed text stating that the BTLs were in libmpi.so
  • Added some cross-references between configure CLI options and advice to packagers
  • Clarified an example with a longer comment
  • Removed some TODO labels

@jsquyres
Copy link
Member Author

Mellanox CI has some internal error right now (failing to pull a docker image).

@jsquyres
Copy link
Member Author

bot:aws:retest

@jsquyres
Copy link
Member Author

Same Mellanox CI internal failure as yesterday:

/usr/bin/docker pull rdmz-harbor.rdmz.labs.mlnx/hpcx/ompi_ci:latest
Error response from daemon: unknown: repository hpcx/ompi_ci not found

@open-mpi open-mpi deleted a comment from azure-pipelines bot Sep 22, 2022
@open-mpi open-mpi deleted a comment from azure-pipelines bot Sep 22, 2022
@open-mpi open-mpi deleted a comment from azure-pipelines bot Sep 22, 2022
@jsquyres
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@open-mpi open-mpi deleted a comment from azure-pipelines bot Sep 23, 2022
@jsquyres jsquyres merged commit c95a01f into open-mpi:main Sep 23, 2022
@jsquyres jsquyres deleted the pr/more-random-docs-updates branch September 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants