Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted 55 files from nroff to markdown #8263

Conversation

Colton-K
Copy link
Contributor

@Colton-K Colton-K commented Dec 2, 2020

There are a couple that have links that won't work, I didn't know what to do for something like socket(3SOCKET) or mpirun(1).

The links that won't work are in MPI_Comm_join.md, MPI_Comm_spawn.md, and MPI_Comm_spawn_multiple

Signed-off-by: Colton Kammes ckammes@nd.edu

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following files are somehow empty:

  • MPI_File_f2c.md
  • MPI_File_c2f.md

ompi/mpi/man/man3/MPI_Comm_f2c.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_Comm_f2c.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_Comm_get_errhandler.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_Comm_remote_size.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_Comm_set_info.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/Makefile.am Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_File_get_size.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_File_get_info.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_File_get_info.md Outdated Show resolved Hide resolved
ompi/mpi/man/man3/MPI_File_get_group.md Outdated Show resolved Hide resolved
Signed-off-by: Colton Kammes <ckammes@nd.edu>
@Colton-K Colton-K force-pushed the pr/mpi_comm_f2c_to_mpi_file_get_view branch from 13f4dd9 to cf4cdee Compare December 3, 2020 02:59

|Key|Type|Description|
|---|---- |-----------|
|host|char *|Host on which the process should be|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be picky here, but could we put all the text for one cell on one line? That would let Markdown render it in a single row with wrapped text lines. I.e.:

Suggested change
|host|char *|Host on which the process should be|
|host|char *|Host on which the process should be spawned. See the orte_host man page for an explanation of how this will be used.|

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't going to do it like that because then the lines would have to be longer than the 80 character limit for the markdown render to not be confused

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, the renderer has a limit of 80-character lines? Bummer! Ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the one renderer which makes it viewable in the terminal. I was just going off earlier when you told me that open-mpi sticks to the 80 character line limit. I think parsedown is capable of more if you'd like me to ignore line length though.

#include <mpi.h>

int MPI_Comm_spawn_multiple(int count, char *array_of_commands[],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget this one.

_ i-1 | _ i |
\ n , to | \ n | -1
/_ j=1 i |_ /_ j=1 j \_|
'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm -- somehow the epsilons are still not rendering properly in the above paragraph.

The following keys for `info` are recognized in `"#PACKAGE_NAME#".`
(The reserved values mentioned in Section 5.3.4 of the MPI-2 standard
are not implemented.)
|Key|Type|Description|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table isn't rendering properly -- perhaps because the Epsilons above aren't rendered properly, and that leads to some stray characters that confuse the markdown renderer...?

but others are set to false (or are unset), `MPI_ERR_INFO` will be
returned.

Note that in `#PACKAGE_NAME#`, the first array location in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's cut it out then. I.e.:

Suggested change
Note that in `#PACKAGE_NAME#`, the first array location in
Note that in this MPI implementation, the first array location in

|(0,0) |MPI_Dims_create(7, 2, dims)| (7,1)|
|(0,3,0) |MPI_Dims_create(6, 3, dims)| (2,3,1)|
|(0,3,0) |MPI_Dims_create(7, 3, dims)| erroneous call|
|-----------|---------------------------|------------------|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last line in this table somehow isn't rendering correctly.

#include <mpi.h>

int MPI_Exscan(const void *sendbuf, void *recvbuf, int count,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch these blank lines in the C bindings. I stopped noting them and didn't mark them in every man page where I saw them -- you might want to check the generated .md files for blank lines in the C bindings.

`MPI_Comm_f2c`, `MPI_Comm_c2f`, `MPI_File_f2c`, `MPI_File_c2f`, `MPI_Info_f2c,`
`MPI_Info_c2f`, `MPI_Message_f2c`, `MPI_Message_c2f`, `MPI_Op_f2c`, `MPI_Op_c2f,`
`MPI_Request_f2c`, `MPI_Request_c2f`, `MPI_Type_f2c`, `MPI_Type_c2f,`
MPI_Win_f2c, MPI_Win_c2f - Translates a C handle into a Fortran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MPI_Win_f2c, MPI_Win_c2f - Translates a C handle into a Fortran
`MPI_Win_f2c`, `MPI_Win_c2f` - Translates a C handle into a Fortran

The MPI standard prescribes portable Fortran syntax for the `OFFSET` and
`DISP` arguments only for Fortran 90. Sun FORTRAN 77 users may use the
non-portable syntax
or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there supposed to be something different here?

@jsquyres
Copy link
Member

All of this content ended up getting used, but as part of the larger convert-to-Sphinx-and-ReStructured-Text effort in #8329. I'm closing this PR without merging, but know that we used all of this work as part of the behind-the-scenes work in #8329.

@jsquyres jsquyres closed this Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants