Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4.1.x: romio321 gpfs, change stat64 to stat #9855

Closed
wants to merge 1 commit into from
Closed

v4.1.x: romio321 gpfs, change stat64 to stat #9855

wants to merge 1 commit into from

Conversation

markalle
Copy link
Contributor

@markalle markalle commented Jan 10, 2022 •
edited by jsquyres
Loading

This is a one-off fix for romio321, but matches what's in romio master

Signed-off-by: Mark Allen markalle@us.ibm.com

It also matches a change we made over in Spectrum MPI a long time ago.

bot:notacherrypick

Refs #9842

@markalle markalle mentioned this pull request Jan 10, 2022
Open
@markalle
romio321 gpfs, change stat64 to stat
cad91e9 
This is a one-off fix for romio321, but matches what's in romio master

Signed-off-by: Mark Allen <markalle@us.ibm.com>
bot:notacherrypick
@markalle markalle force-pushed the romio321_stat64_v41x branch from 925c216 to cad91e9 Compare January 10, 2022 21:41
@jsquyres jsquyres added this to the v4.1.3 milestone Jan 10, 2022
@jsquyres jsquyres changed the title romio321 gpfs, change stat64 to stat v4.1.x: romio321 gpfs, change stat64 to stat Jan 10, 2022
@markalle
Copy link
Contributor Author

I'm not sure how romio is handled in master now, but my rough understanding is we're moving toward pulling romio straight from mpich (or are we just using ompio these days?). Anyway I don't see an ad_gpfs_open.c for example in the OMPI source tree in master and I don't think we're intending to have our own copy of romio going forward. So I think this fix is only needed in v4.1.x and v4.0.x

@gpaulsen
Copy link
Member

For our release branch, note that, this fix is included in MPICH 3.3.x ROMIO, but our OMPI release branches are still at ROMIO 3.2.1. (see: https://github.com/pmodels/mpich/blob/3.3.x/src/mpi/romio/adio/ad_gpfs/ad_gpfs_open.c)

@gpaulsen
Copy link
Member

RE: master branch,
We pull released versions of MPICH. We’ve tried not to make local commits that aren’t upstream, because then we lose them the next time we pull a released version of MPICH.
but we don’t track MPICH master or anything like that.

@gpaulsen gpaulsen requested a review from awlauria January 18, 2022 16:22
@awlauria
Copy link
Contributor

pmodels/mpich@90a0fd5

is the romio commit that fixed this in master. First release is ROMIO v3.3 by the tags.

@gpaulsen gpaulsen mentioned this pull request Jan 18, 2022
Merged
@gpaulsen
Copy link
Member

Community asked that we document this one-off ROMIO fix in the git commit.
I couldn't force push to @markalle 's fork, so I created a new PR to replace this one here: #9887

@gpaulsen gpaulsen closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awlauria awlauria awlauria approved these changes

Assignees
No one assigned
Labels
Target: v4.1.x
Projects
None yet
Milestone
v4.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@markalle @gpaulsen @awlauria @jsquyres