Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Instances of SpanContext Immutable #3

Closed
wants to merge 1 commit into from
Closed

Make Instances of SpanContext Immutable #3

wants to merge 1 commit into from

Conversation

JasonXZLiu
Copy link

@JasonXZLiu JasonXZLiu commented Sep 17, 2020 •
edited
Loading

Description

This PR makes instances of SpanContext Immutable to match the OpenTelemetry specifications.

Fixes #: open-telemetry#1002

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests have been added to test the following behavior:

  • instantiating a SpanContext returns an object with the correct values set
  • trying to change an attribute throws TypeError
  • after trying to change an attribute, the object maintains its original values

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Note: changelogs + documentation did not need updating as SpanContext is already assumed to be Immutable (from the specifications).

@JasonXZLiu JasonXZLiu marked this pull request as ready for review September 17, 2020 16:49
@JasonXZLiu JasonXZLiu changed the title [WIP] Make Instances of SpanContext Immutable Make Instances of SpanContext Immutable Sep 17, 2020
@JasonXZLiu JasonXZLiu closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JasonXZLiu