Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reactivity-API for all APIs #369

Closed
mbeckem opened this issue Oct 23, 2024 · 1 comment
Closed

Use reactivity-API for all APIs #369

mbeckem opened this issue Oct 23, 2024 · 1 comment

Comments

@mbeckem
Copy link
Contributor

mbeckem commented Oct 23, 2024

Use the reactivity-API for all APIs.

This issue seeks to replace all usages of custom state synchronization (raw events etc.) with a unified approach using the reactivity API.
Shared, reactive data should be placed into signals where it can be watched (or derived) efficiently.

  • Packages
    • authentication (and authentication-keycloak): for authentication state
    • editing (workflow state)
    • map (MapModel and associated sub-objects (e.g. layers))
      • new APIs should be introduced to get the center, scale, extent, etc. using the reactivity API (based on the ol map)
      • hooks used across the project (e.g. useSublayers, useCenter, useScale, ...) can be simplified using useReactiveSnapshot
    • selection (status of SelectionSource)
  • Decide if we should keep supporting the old events for backwards compatibility
@mbeckem
Copy link
Contributor Author

mbeckem commented Oct 23, 2024

PR: #347

@antoniave antoniave assigned antoniave and unassigned arnevogt Oct 23, 2024
antoniave added a commit that referenced this issue Oct 24, 2024
---------

Co-authored-by: Antonia van Eek <a.vaneek@conterra.de>
Co-authored-by: Arne Vogt <a.vogt@52north.org>
@antoniave antoniave removed their assignment Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants