Add an optional "fieldOwner" field to set when injecting the caBundle #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the cert-rotator with CI/CD systems such as argoCD, the injection of the caBundle makes the cd system to reconcile it again. By setting the field owner, we instruct the cd system that the field is managed by an external component so it will ignore those updates. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
+ Coverage 56.33% 56.71% +0.38%
==========================================
Files 1 1
Lines 568 573 +5
==========================================
+ Hits 320 325 +5
Misses 183 183
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
maxsmythe
approved these changes
Aug 24, 2023
Yep, I am not exactly sure on how it works. My first attempt was to convert the apply to patch, but the same option works with apply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the cert-rotator with CI/CD systems such as argoCD, the injection of the caBundle makes the cd system to reconcile it again. By setting the field owner, we instruct the cd system that the field is managed by an external component so it will ignore those updates.
This was raised in MetalLB in metallb/metallb#1681