-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConstraintTemplate have no maximum name length #116
Comments
Would we do this in the ConstraintTemplate CRD, or programmatically in How much do ConstraintTemplateStatus resources need to add to the name? If at most 63 characters, then ConstraintTemplateNames can be up to 253-63=190 characters long. |
Probably both? Putting it in the CRD would be most reliable for the K8s API server (not reliant on validation webhook being up), but we'd want it in our code for things like |
Gatekeeper breaks with longer template names. Fixes open-policy-agent#116 Signed-off-by: Max Smythe <smythe@google.com>
Gatekeeper breaks with longer template names. Fixes open-policy-agent#116 Signed-off-by: Max Smythe <smythe@google.com>
This is provided by controller runtime, but we want to double-check this doesn't regress. Fixes open-policy-agent#116 Signed-off-by: Max Smythe <smythe@google.com>
This is provided by controller runtime, but we want to double-check this doesn't regress. Fixes open-policy-agent#116 Signed-off-by: Max Smythe <smythe@google.com>
This is provided by controller runtime, but we want to double-check this doesn't regress. Fixes #116 Signed-off-by: Max Smythe <smythe@google.com> Signed-off-by: Max Smythe <smythe@google.com>
Constraint templates do not currently have a maximum name length.
It is necessary to cap the maximum possible constraint template name length to leave room for ConstraintTemplateStatus resources. Constraints have a maximum name length of 63 chars, we can be a bit more generous with Templates, if necessary.
Here is the PR that caps constraint name length, for reference:
b745ff7#diff-f0ceecee7c4c5529a7457604249a3c7e04bf92c547d1b42bf9af2e710cc4ea07
The text was updated successfully, but these errors were encountered: