Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip broken test TestRemoteClientE2E #144

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

willbeason
Copy link
Member

@willbeason willbeason commented Oct 6, 2021

This test currently can't pass, so I've added t.Skip so that
"go test ./..." doesn't try to execute it. This makes running go tests
easier.

Once the features it relies on are ready (and it is possible for the
test to pass) we can remove the skip.

Signed-off-by: Will Beason willbeason@google.com

This test currently can't pass, so I've added t.Skip so that
"go test ./..." doesn't try to execute it. This makes running go tests
annoying.

Once the features it relies on are ready (and it is possible for the
test to pass) we can remove the skip.

Signed-off-by: Will Beason <willbeason@google.com>
@willbeason willbeason self-assigned this Oct 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #144 (64102ed) into master (7a19e4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #144   +/-   ##
=======================================
  Coverage   41.51%   41.51%           
=======================================
  Files          52       52           
  Lines        3122     3122           
=======================================
  Hits         1296     1296           
  Misses       1435     1435           
  Partials      391      391           
Flag Coverage Δ
unittests 41.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a19e4e...64102ed. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan
Copy link
Member

sozercan commented Oct 6, 2021

why is CI not failing? do we not run the tests for this?

@maxsmythe
Copy link
Contributor

We only test subdirs of pkg:

go test ./pkg/... -coverprofile cover.out

@sozercan
Copy link
Member

sozercan commented Oct 6, 2021

I see, looks like this is the only test in there

@willbeason
Copy link
Member Author

For posterity: the Gatekeeper Test failure is non-blocking - it is being worked on separately. This change would not impact Gatekeeper Test passing/failing.

@willbeason willbeason merged commit 5ce1a9b into open-policy-agent:master Oct 7, 2021
@willbeason willbeason deleted the skip-broken-test branch October 7, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants