-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip broken test TestRemoteClientE2E #144
Skip broken test TestRemoteClientE2E #144
Conversation
This test currently can't pass, so I've added t.Skip so that "go test ./..." doesn't try to execute it. This makes running go tests annoying. Once the features it relies on are ready (and it is possible for the test to pass) we can remove the skip. Signed-off-by: Will Beason <willbeason@google.com>
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
=======================================
Coverage 41.51% 41.51%
=======================================
Files 52 52
Lines 3122 3122
=======================================
Hits 1296 1296
Misses 1435 1435
Partials 391 391
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
why is CI not failing? do we not run the tests for this? |
We only test subdirs of frameworks/constraint/Makefile Line 15 in 7a19e4e
|
I see, looks like this is the only test in there |
For posterity: the Gatekeeper Test failure is non-blocking - it is being worked on separately. This change would not impact Gatekeeper Test passing/failing. |
This test currently can't pass, so I've added t.Skip so that
"go test ./..." doesn't try to execute it. This makes running go tests
easier.
Once the features it relies on are ready (and it is possible for the
test to pass) we can remove the skip.
Signed-off-by: Will Beason willbeason@google.com