Add unit tests for regowriter #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becky-hd
force-pushed
the
regowriter-ut
branch
from
438b079
to
adcdb1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 45.20% 46.34% +1.13%
==========================================
Files 59 59
Lines 2796 2792 -4
==========================================
+ Hits 1264 1294 +30
+ Misses 1290 1256 -34
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
It looks like the lint test is failing? Also, feel free to assign Will as the reviewer once this PR is ready for a look. |
becky-hd
force-pushed
the
regowriter-ut
branch
from
adcdb1f
to
39e7c42
Compare
willbeason
requested changes
Nov 23, 2021
becky-hd
force-pushed
the
regowriter-ut
branch
8 times, most recently
from
7eb63ca
to
7fbe16d
Compare
willbeason
requested changes
Dec 7, 2021
becky-hd
force-pushed
the
regowriter-ut
branch
from
7fbe16d
to
647b198
Compare
willbeason
requested changes
Dec 9, 2021
becky-hd
force-pushed
the
regowriter-ut
branch
from
647b198
to
69de0f6
Compare
becky-hd
force-pushed
the
regowriter-ut
branch
4 times, most recently
from
1868dfa
to
4328517
Compare
willbeason
requested changes
Dec 13, 2021
becky-hd
force-pushed
the
regowriter-ut
branch
from
4328517
to
c0c0bd5
Compare
willbeason
requested changes
Dec 13, 2021
becky-hd
force-pushed
the
regowriter-ut
branch
from
89dea70
to
5c91c12
Compare
willbeason
approved these changes
Dec 14, 2021
maxsmythe
requested changes
Jan 13, 2022
becky-hd
force-pushed
the
regowriter-ut
branch
2 times, most recently
from
1a0663d
to
a205721
Compare
julianKatz
approved these changes
Jan 13, 2022
Rewrite TestRegoRewriter to test AddLib and AddEntryPoint separately Add go113 error for regowriter error assertion Minor refactoring for rewriteImportPath Signed-off-by: Becky Huang <beckyhd@google.com>
…#157 Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
becky-hd
force-pushed
the
regowriter-ut
branch
from
7dd4f7e
to
352842a
Compare
Correct - this is currently a transient issue because we changed where validation is done. We're adding a dedicated "ValidateConstraintTemplate" method instead of having callers rely on implementation details of "CreateCRD". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase unit test coverage for constraint/pkg/regorewriter #157