-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for regowriter #161
Conversation
438b079
to
adcdb1f
Compare
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 45.20% 46.34% +1.13%
==========================================
Files 59 59
Lines 2796 2792 -4
==========================================
+ Hits 1264 1294 +30
+ Misses 1290 1256 -34
Partials 242 242
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It looks like the lint test is failing? Also, feel free to assign Will as the reviewer once this PR is ready for a look. |
adcdb1f
to
39e7c42
Compare
7eb63ca
to
7fbe16d
Compare
7fbe16d
to
647b198
Compare
647b198
to
69de0f6
Compare
1868dfa
to
4328517
Compare
4328517
to
c0c0bd5
Compare
89dea70
to
5c91c12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Becky!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 nit, one type conversion concern.
1a0663d
to
a205721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits, otherwise LGTM.
@becky-hd Looks like GK tests are failing, is this expected?
Rewrite TestRegoRewriter to test AddLib and AddEntryPoint separately Add go113 error for regowriter error assertion Minor refactoring for rewriteImportPath Signed-off-by: Becky Huang <beckyhd@google.com>
…#157 Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
7dd4f7e
to
352842a
Compare
Correct - this is currently a transient issue because we changed where validation is done. We're adding a dedicated "ValidateConstraintTemplate" method instead of having callers rely on implementation details of "CreateCRD". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
Increase unit test coverage for constraint/pkg/regorewriter #157