-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary usage of gomega libraries #166
Conversation
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 44.92% 44.92%
=======================================
Files 59 59
Lines 2776 2776
=======================================
Hits 1247 1247
Misses 1286 1286
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ed137f5
to
cedfac4
Compare
None of our current tests need gomega mocking, and the tests are clearer/more flexible/more standardized using the core testing.T library. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
constraint/pkg/apis/templates/v1/constrainttemplate_types_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Will Beason <willbeason@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. LGTM
Wonderfully, this reduces our imported library code by ~180,000 lines.