Remove unnecessary usage of gomega libraries #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
=======================================
Coverage 44.92% 44.92%
=======================================
Files 59 59
Lines 2776 2776
=======================================
Hits 1247 1247
Misses 1286 1286
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
willbeason
force-pushed
the
no-mocks
branch
2 times, most recently
from
ed137f5
to
cedfac4
Compare
None of our current tests need gomega mocking, and the tests are clearer/more flexible/more standardized using the core testing.T library. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
requested review from
julianKatz and
maxsmythe
and removed request for
julianKatz
julianKatz
reviewed
Dec 10, 2021
constraint/pkg/apis/templates/v1/constrainttemplate_types_test.go
Outdated
Show resolved
Hide resolved
julianKatz
approved these changes
Dec 10, 2021
Signed-off-by: Will Beason <willbeason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wonderfully, this reduces our imported library code by ~180,000 lines.