-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove client.Reset #169
Conversation
Now that gatekeeper no longer uses it, there are no callers. All tests have previously been migrated off to avoid potential crosstalk. It's best to wait until we have solid plans for a remote implementation to consider modifying the design of Client. This makes the implementation work for reo compilation sharding/optimization significantly easier. Signed-off-by: Will Beason <willbeason@google.com>
This is no longer used so it can be safely deleted. Signed-off-by: Will Beason <willbeason@google.com>
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 45.00% 44.92% -0.09%
==========================================
Files 59 59
Lines 2795 2776 -19
==========================================
- Hits 1258 1247 -11
+ Misses 1295 1286 -9
- Partials 242 243 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ignore the gatekeeper failure - that is fixed by open-policy-agent/gatekeeper#1762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gatekeeper_test is failing |
This is expected and is fixed by the PR linked in the above comment. |
Now that gatekeeper no longer uses it, there are no callers. All tests
have previously been migrated off to avoid potential crosstalk.
This makes the implementation work for rego compilation
sharding/optimization significantly easier.
Signed-off-by: Will Beason willbeason@google.com