refactor: Remove client.Reset #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that gatekeeper no longer uses it, there are no callers. All tests have previously been migrated off to avoid potential crosstalk. It's best to wait until we have solid plans for a remote implementation to consider modifying the design of Client. This makes the implementation work for reo compilation sharding/optimization significantly easier. Signed-off-by: Will Beason <willbeason@google.com>
This is no longer used so it can be safely deleted. Signed-off-by: Will Beason <willbeason@google.com>
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
- Coverage 45.00% 44.92% -0.09%
==========================================
Files 59 59
Lines 2795 2776 -19
==========================================
- Hits 1258 1247 -11
+ Misses 1295 1286 -9
- Partials 242 243 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Ignore the gatekeeper failure - that is fixed by open-policy-agent/gatekeeper#1762 |
|
gatekeeper_test is failing |
This is expected and is fixed by the PR linked in the above comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that gatekeeper no longer uses it, there are no callers. All tests
have previously been migrated off to avoid potential crosstalk.
This makes the implementation work for rego compilation
sharding/optimization significantly easier.
Signed-off-by: Will Beason willbeason@google.com