Add ToMatcher to TargetHandler #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
+ Coverage 44.92% 44.94% +0.02%
==========================================
Files 59 59
Lines 2776 2779 +3
==========================================
+ Hits 1247 1249 +2
- Misses 1286 1287 +1
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Failure from Gatekeeper Test is expected as this changes the TargetHandler interface. |
added 3 commits
January 12, 2022 08:23
The idea here is that we can cache the golang match criteria for each Constraint, rather than parsing it out each time. Also fix bug in SemanticEqual where one Constraint has Object defined and the other does not. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
to-matcher
branch
from
9c2d097
to
b3bed95
Compare
julianKatz
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is that we can cache the golang match criteria for each
Constraint, rather than parsing it out each time. This PR does not actually implement the behavior; it just defines the interface so that we can start using it in Gatekeeper.
Also fix bug in SemanticEqual where one Constraint has Object defined
and the other does not.
Signed-off-by: Will Beason willbeason@google.com