Rewrite test TargetHandler #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
- Coverage 45.70% 45.66% -0.05%
==========================================
Files 59 60 +1
Lines 2866 2847 -19
==========================================
- Hits 1310 1300 -10
+ Misses 1309 1302 -7
+ Partials 247 245 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
willbeason
force-pushed
the
query
branch
2 times, most recently
from
2f9a307
to
9e5361e
Compare
added 13 commits
January 14, 2022 09:17
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
This means the merge conflict won't cause compilation errors. Signed-off-by: Will Beason <willbeason@google.com>
Resolve various issues from now-merged commits, such as interface changes. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
changed the title
added 2 commits
January 18, 2022 11:29
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
ritazh
reviewed
Jan 19, 2022
ritazh
reviewed
Jan 19, 2022
ritazh
reviewed
Jan 19, 2022
|
Gatekeeper Test is failing |
Signed-off-by: Will Beason <willbeason@google.com>
Yes, this is expected for right now. @becky-hd is working on changing where/when we do validation. Right now Gatekeeper relies on CreateCRD to fail under certain conditions, when really we should have a dedicated ValidateCRD method. |
added 2 commits
January 19, 2022 13:11
Since it is needed by several layers of abstraction, it should be in its own package. Ditto the test handler type. Thanks to @davis-haba for identifying this Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big idea here is that the current TargetHandler makes it hard to test several things we want to have good tests for before we can safely shard rego environments. At its core, this PR is about this new handler and the resulting test changes. This makes
pkg/client/clienttest/handler.goa good starting point for reviewing this PR.I've broken "CRD Helpers" into individual methods and removed "CRDHelper" - this type was becoming a dumping ground of tenuously-related validation and constructing CRDs, ConstraintTemplates, and Constraints. Only one method used the single member of this type (the schema). So I've broken this into the
client/crdspackage. The package could probably be better-named since not all of the functions in "CRDHelper" dealt with CRDs. Let me know if you have a better idea!Since the test Handler needs to import the
clientpackage and is in a test package, allclienttests need to be in theclient_testpackage. All functionality they rely on then needs to be exported byclient. This change is responsible for much of the code changes.Lastly, the new test TargetHandler is much more flexible than the old one. This ended up making a lot of logic for existing E2E tests obsolete, so I've rewritten them. This makes the distinction between "e2e" and non-"e2e" tests a bit arbitrary as both flavors are using the same setup code (and have the same flexibility). I've arbitrarily decided to stick with the current convention that "e2e" tests are those which exercise "Review" or "Audit", or test sequences of behaviors (such as adding a Constraint, then deleting its Template).
Some changes in this PR are transitory - they are intended to be fixed in later PRs. These relate to making certain fields/methods exported which shouldn't be.
AllowedDataFields,ParseModule, andRequireModuleRulesare examples of these. They will be moved toclient/drivers/localsince that's the only location which should need that logic.