Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export external data default send request function #205

Merged

Conversation

chewong
Copy link
Member

@chewong chewong commented Mar 25, 2022

Eliminating code duplication by exporting the external data default send request function so that we don't have to define the same function in gatekeeper.

Related PR: open-policy-agent/gatekeeper#1891

Signed-off-by: Ernest Wong <chuwon@microsoft.com>
Signed-off-by: GitHub <noreply@github.com>
@maxsmythe
Copy link
Contributor

Marked as draft, time to change?

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chewong chewong marked this pull request as ready for review March 25, 2022 19:23
@chewong chewong merged commit 98cb422 into open-policy-agent:master Mar 31, 2022
@chewong chewong deleted the export-external-data-request-fn branch March 31, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants