-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Don't cache Constraint status #216
perf: Don't cache Constraint status #216
Conversation
Constraint status is ephemeral and callers should not be relying on our cached version of the status field. Also, status can be very large, and caching it wastes space. Signed-off-by: Will Beason <willbeason@google.com>
14715e2
to
5f82a87
Compare
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 46.29% 46.33% +0.03%
==========================================
Files 64 64
Lines 2819 2821 +2
==========================================
+ Hits 1305 1307 +2
Misses 1297 1297
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Will Beason <willbeason@google.com>
ae2f449
to
1d5a5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Constraint status is ephemeral and callers should not be relying on our
cached version of the status field. Also, status can be very large, and
caching it wastes space.
Note that the Driver already drops
status
as it only preservesspec.parameters
.Signed-off-by: Will Beason willbeason@google.com
Fixes #209