perf: Don't cache Constraint status #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constraint status is ephemeral and callers should not be relying on our cached version of the status field. Also, status can be very large, and caching it wastes space. Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
nocache-status
branch
from
14715e2
to
5f82a87
Compare
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 46.29% 46.33% +0.03%
==========================================
Files 64 64
Lines 2819 2821 +2
==========================================
+ Hits 1305 1307 +2
Misses 1297 1297
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
April 7, 2022 12:15
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
nocache-status
branch
from
ae2f449
to
1d5a5e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraint status is ephemeral and callers should not be relying on our
cached version of the status field. Also, status can be very large, and
caching it wastes space.
Note that the Driver already drops
statusas it only preservesspec.parameters.Signed-off-by: Will Beason willbeason@google.com
Fixes #209