-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TLS support for External Data Providers #226
feat: TLS support for External Data Providers #226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 49.39% 50.22% +0.82%
==========================================
Files 64 64
Lines 4154 4255 +101
==========================================
+ Hits 2052 2137 +85
- Misses 1866 1879 +13
- Partials 236 239 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments, but mostly LGTM
a78800b
to
b047790
Compare
67caae8
to
89774ad
Compare
8d5168d
to
42a8425
Compare
42a8425
to
dc83a78
Compare
44ab592
to
18159dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pending failed gatekeeper tests
the gatekeeper test won't pass because this PR contains a minor breaking change (I changed the function signature of |
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
b283b3a
to
ecd4d23
Compare
Signed-off-by: GitHub <noreply@github.com>
ecd4d23
to
7222ec1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after 1 comment nit, sorry for the slow review process
Signed-off-by: GitHub <noreply@github.com>
Design doc: https://docs.google.com/document/d/1GjV3WeC2bgQ3j37_mMpY9hr7YOAqzSJ6jDSu-DVrcmU/edit#
This PR adds two new fields to the Provider CRD - caBundle and insecureTLSSkipVerify. If the provider is using HTTPS scheme for their provider and presents a valid caBundle, we will inject it into our HTTP client before making an external data request. We will also inject Gatekeeper's certificate into our HTTP client in case the provider wants to establish mutual trust.