Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to opa 0.45 #253

Merged
merged 3 commits into from
Oct 12, 2022
Merged

bump to opa 0.45 #253

merged 3 commits into from
Oct 12, 2022

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Oct 7, 2022

Signed-off-by: Sertac Ozercan sozercan@gmail.com

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@maxsmythe
Copy link
Contributor

maxsmythe commented Oct 7, 2022

Lint is failing. Do we need to run go mod tidy?

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>

linters:
disable-all: true
enable:
- deadcode
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are deprecated linters

@codecov-commenter
Copy link

Codecov Report

Base: 50.30% // Head: 50.30% // No change to project coverage 👍

Coverage data is based on head (330261f) compared to base (a3d297b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   50.30%   50.30%           
=======================================
  Files          64       64           
  Lines        4266     4266           
=======================================
  Hits         2146     2146           
  Misses       1881     1881           
  Partials      239      239           
Flag Coverage Δ
unittests 50.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/frameworks/constraint/pkg/regorewriter/errors.go 33.33% <0.00%> (ø)
.../frameworks/constraint/pkg/regorewriter/sources.go 16.41% <0.00%> (ø)
...constraint/pkg/client/drivers/remote/httpclient.go 14.20% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 03ef13d into open-policy-agent:master Oct 12, 2022
@sozercan sozercan deleted the opa045 branch October 12, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants