Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements external data response cache #334

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented Jun 8, 2023

No description provided.

@nilekhc nilekhc changed the title feat: implements external data response cache [WIP] feat: implements external data response cache Jun 9, 2023
constraint/pkg/client/drivers/rego/builtin.go Outdated Show resolved Hide resolved
constraint/pkg/externaldata/cache.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.56 🎉

Comparison is base (6ccacf8) 53.90% compared to head (30b4545) 54.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   53.90%   54.47%   +0.56%     
==========================================
  Files          67       67              
  Lines        4682     4760      +78     
==========================================
+ Hits         2524     2593      +69     
- Misses       1889     1897       +8     
- Partials      269      270       +1     
Flag Coverage Δ
unittests 54.47% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nilekhc nilekhc changed the title [WIP] feat: implements external data response cache feat: implements external data response cache Jun 14, 2023
@nilekhc nilekhc force-pushed the external-data-cache branch 2 times, most recently from 9cfbefd to 3846ab7 Compare June 29, 2023 00:04
@nilekhc nilekhc requested a review from maxsmythe June 29, 2023 00:14
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nits

constraint/pkg/client/drivers/rego/builtin.go Outdated Show resolved Hide resolved
constraint/pkg/client/drivers/rego/builtin.go Outdated Show resolved Hide resolved
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit c058812 into open-policy-agent:master Jul 12, 2023
@nilekhc nilekhc deleted the external-data-cache branch July 12, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants