-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implements external data response cache #334
feat: implements external data response cache #334
Conversation
1f6c82a
to
30b4545
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #334 +/- ##
==========================================
+ Coverage 53.90% 54.47% +0.56%
==========================================
Files 67 67
Lines 4682 4760 +78
==========================================
+ Hits 2524 2593 +69
- Misses 1889 1897 +8
- Partials 269 270 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
30b4545
to
c6a1256
Compare
c6a1256
to
77cf5aa
Compare
9cfbefd
to
3846ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after nits
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
3846ab7
to
06a54a8
Compare
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
No description provided.