Use k8s client lib v0.30.1

[tamalsaha]

No description provided.

[sozercan]

@tamalsaha thanks for the pr! can you run make vendor manifests and commit the changes when you get a chance?

[tamalsaha]

@sozercan done. PTAL!

[davidgamero]

+1

[tamalsaha]

There is a breaking api change between 0.30.0 and 0.30.3 . It is worth exploring if that should be fixed here.
https://github.com/kubernetes/kubernetes/blob/6834a1ef3d928f6f7e00e801a43c37bead75dbe9/pkg/apis/admissionregistration/validation/validation.go#L1304

compiler, err := plugincel.NewCompositedCompiler(environment.MustBaseEnvSet(environment.DefaultCompatibilityVersion(), strictCost))

The strictCost boolean parameter has been newly added

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.83%. Comparing base (76869f8) to head (a05810c).
Report is 28 commits behind head on master.

Files	Patch %	Lines
...straint/pkg/client/drivers/k8scel/schema/schema.go	0.00%	3 Missing ⚠️
...kg/client/drivers/k8scel/transform/cel_snippets.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
- Coverage   54.68%   52.83%   -1.85%     
==========================================
  Files          71      104      +33     
  Lines        5241     6518    +1277     
==========================================
+ Hits         2866     3444     +578     
- Misses       2073     2713     +640     
- Partials      302      361      +59     

Flag	Coverage Δ
unittests	52.83% <37.50%> (-1.85%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ritazh]

There is a breaking api change between 0.30.0 and 0.30.3 . It is worth exploring if that should be fixed here. https://github.com/kubernetes/kubernetes/blob/6834a1ef3d928f6f7e00e801a43c37bead75dbe9/pkg/apis/admissionregistration/validation/validation.go#L1304

compiler, err := plugincel.NewCompositedCompiler(environment.MustBaseEnvSet(environment.DefaultCompatibilityVersion(), strictCost))

The strictCost boolean parameter has been newly added

We could deal with it as a separate follow up PR to keep this PR smaller. wdyt?

[tamalsaha]

There is a breaking api change between 0.30.0 and 0.30.3 . It is worth exploring if that should be fixed here. https://github.com/kubernetes/kubernetes/blob/6834a1ef3d928f6f7e00e801a43c37bead75dbe9/pkg/apis/admissionregistration/validation/validation.go#L1304
compiler, err := plugincel.NewCompositedCompiler(environment.MustBaseEnvSet(environment.DefaultCompatibilityVersion(), strictCost))
The strictCost boolean parameter has been newly added

We could deal with it as a separate follow up PR to keep this PR smaller. wdyt?

Sounds good to me.

[sozercan]

Looks like this breaks GK tests (these are informative), we'll need to handle that when we vendor this in.

[sozercan]

Thank you! LGTM