-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use k8s client lib v0.30.1 #435
Use k8s client lib v0.30.1 #435
Conversation
@tamalsaha thanks for the pr! can you run |
@sozercan done. PTAL! |
+1 |
There is a breaking api change between 0.30.0 and 0.30.3 . It is worth exploring if that should be fixed here.
The |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 54.68% 52.83% -1.85%
==========================================
Files 71 104 +33
Lines 5241 6518 +1277
==========================================
+ Hits 2866 3444 +578
- Misses 2073 2713 +640
- Partials 302 361 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We could deal with it as a separate follow up PR to keep this PR smaller. wdyt? |
Sounds good to me. |
Signed-off-by: Tamal Saha <tamal@appscode.com>
Looks like this breaks GK tests (these are informative), we'll need to handle that when we vendor this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
No description provided.