Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test gomod #63

Merged
merged 3 commits into from
Jan 6, 2020
Merged

Test gomod #63

merged 3 commits into from
Jan 6, 2020

Conversation

maxsmythe
Copy link
Contributor

@maxsmythe maxsmythe commented Jan 4, 2020 •
edited
Loading

Fixes #62

@maxsmythe
Update vendor versions
36e68d2 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Add linter and fix lint errors
a4542ed 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe mentioned this pull request Jan 4, 2020
Closed
@maxsmythe
Use test docker container
0b1303d 
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe
Copy link
Contributor Author

@tsandall this change eliminates the need for replace directives in the gomod files of any project that uses this library.

tsandall
tsandall approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@tsandall tsandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM cc @patrick-east who recently migrated OPA to go mod in case anything jumps out.

@maxsmythe maxsmythe merged commit db06c8a into open-policy-agent:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsandall tsandall tsandall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken downstream dependencies due to replace directive in go.mod
2 participants
@maxsmythe @tsandall