Fix broken tests

Signed-off-by: Max Smythe <smythe@google.com>
open-policy-agent · Jan 24, 2023 · af03bb5 · af03bb5
1 parent 3ce6b43
commit af03bb5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/controller/constrainttemplate/constrainttemplate_controller_test.go b/pkg/controller/constrainttemplate/constrainttemplate_controller_test.go
@@ -580,7 +580,7 @@ violation[{"msg": "denied!"}] {
 
 	// Set up tracker
 	tracker, err := readiness.SetupTracker(mgr, false, false)
-	if err != nil {
+	if err != nil && !strings.Contains(err.Error(), "unable to add new checker because healthz endpoint has already been created") {
 		t.Fatal(err)
 	}
 

diff --git a/pkg/target/target_test.go b/pkg/target/target_test.go
@@ -90,7 +90,7 @@ func TestValidateConstraint(t *testing.T) {
 				"matchExpressions": [{
 					"key": "someKey",
 					"operator": "NotIn",
-					"values": ["some value"]
+					"values": ["some-value"]
 				}]
 			}
 		},
@@ -130,7 +130,7 @@ func TestValidateConstraint(t *testing.T) {
 			ErrorExpected: true,
 		},
 		{
-			Name: "Invalid LabelSelector MatchLels",
+			Name: "Invalid LabelSelector MatchLabels",
 			Constraint: `
 {
 	"apiVersion": "constraints.gatekeeper.sh/v1beta1",
@@ -212,7 +212,7 @@ func TestValidateConstraint(t *testing.T) {
 				"matchExpressions": [{
 					"key": "someKey",
 					"operator": "In",
-					"values": ["some value"]
+					"values": ["some-value"]
 				}]
 			}
 		},
@@ -245,7 +245,7 @@ func TestValidateConstraint(t *testing.T) {
 				"matchExpressions": [{
 					"key": "someKey",
 					"operator": "In",
-					"values": ["some value"]
+					"values": ["some-value"]
 				}]
 			}
 		},