Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We Shouldn't Pass the Full Constraint Object to CT Rego #181

Closed
maxsmythe opened this issue Jul 13, 2019 · 1 comment
Closed

We Shouldn't Pass the Full Constraint Object to CT Rego #181

maxsmythe opened this issue Jul 13, 2019 · 1 comment
Assignees
@maxsmythe
Labels
blocking beta We shouldn't move to beta until this is fixed

Comments

@maxsmythe
Copy link
Contributor

We shouldn't pass the full constraint resource to the template's rego, as that couples the rego to the schema of the constraint implemented by the framework.

I suggest passing only the params, under input.parameters.

As this is a breaking change, it would block beta.
@maxsmythe maxsmythe added the blocking beta We shouldn't move to beta until this is fixed label Jul 13, 2019
@maxsmythe maxsmythe self-assigned this Jul 13, 2019
@maxsmythe
Copy link
Contributor Author

Fixed by #190

@ritazh ritazh closed this as completed Jul 25, 2019
dhaiducek pushed a commit to dhaiducek/gatekeeper that referenced this issue Jul 20, 2023
@openshift-cherrypick-robot @mprahl
Enable CGO explicitly (open-policy-agent#181)
59d343d 
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Co-authored-by: mprahl <mprahl@users.noreply.github.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxsmythe maxsmythe

Labels
blocking beta We shouldn't move to beta until this is fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ritazh @maxsmythe