Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update default min TLS to 1.3 #1866

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Feb 23, 2022

Signed-off-by: Sertac Ozercan sozercan@gmail.com

What this PR does / why we need it:
As discussed in #1424, TLS 1.3 should be default in next version

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #1670

Special notes for your reviewer:

Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
@sozercan sozercan requested a review from a team February 23, 2022 23:37
@codecov-commenter
Copy link

Codecov Report

Merging #1866 (9b448d4) into master (b8bf07f) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   52.18%   52.17%   -0.02%     
==========================================
  Files         100      100              
  Lines        8952     8952              
==========================================
- Hits         4672     4671       -1     
- Misses       3905     3906       +1     
  Partials      375      375              
Flag Coverage Δ
unittests 52.17% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/webhook/common.go 66.00% <ø> (ø)
pkg/watch/replay.go 78.97% <0.00%> (-2.28%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 58.89% <0.00%> (+0.72%) ⬆️
pkg/controller/config/config_controller.go 65.04% <0.00%> (+1.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bf07f...9b448d4. Read the comment docs.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 7740642 into open-policy-agent:master Feb 24, 2022
@sozercan sozercan deleted the tls-1.3 branch February 24, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set TLS 1.3 as default for webhooks
4 participants