Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Prepare v3.9.0-beta.0 release #2016

Merged
merged 1 commit into from
Apr 25, 2022
Merged

chore: Prepare v3.9.0-beta.0 release #2016

merged 1 commit into from
Apr 25, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong requested a review from a team April 22, 2022 00:22
@codecov-commenter
Copy link

Codecov Report

Merging #2016 (2b36f18) into master (9967be0) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2016      +/-   ##
==========================================
- Coverage   54.34%   54.30%   -0.05%     
==========================================
  Files         110      110              
  Lines        9434     9434              
==========================================
- Hits         5127     5123       -4     
- Misses       3918     3921       +3     
- Partials      389      390       +1     
Flag Coverage Δ
unittests 54.30% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/list.go 79.41% <0.00%> (-11.77%) ⬇️
pkg/readiness/object_tracker.go 82.91% <0.00%> (-1.07%) ⬇️
...onstrainttemplate/constrainttemplate_controller.go 54.91% <0.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71351d...2b36f18. Read the comment docs.

@maxsmythe
Copy link
Contributor

What are we putting into v3.9?

@chewong
Copy link
Member

chewong commented Apr 22, 2022

v3.9.0-beta.0 marks the beginning of the development cycle for 3.9. It's documented in our updated release cadence.

This addresses #1935. Per the release cadence:

  • v3.8.0 and future patch releases for 3.8 should live in release-3.8 branch rather than the master branch.
  • we cut v3.9.0-beta.0 from master branch immediately after releasing v3.8.0. v3.9.0-beta.0 is basically v3.8.0 plus some commits on top of it.
  • we can continue cutting betas from master branch if there is an experimental feature users want to try out.

@maxsmythe
Copy link
Contributor

What's the benefit vs. cutting a release from main once we have feature sets that indicate a minor version bump?

Drawbacks:

  • Another branch to keep up-to-date (pull requests are against main branch
  • Broadcasts that there is a pending minor version bump, which is not necessarily true
  • Extra PR to review as part of release process

@ritazh
Copy link
Member

ritazh commented Apr 23, 2022

Another branch to keep up-to-date (pull requests are against main branch

@maxsmythe this new tag is created against master, not a new release branch.

@maxsmythe
Copy link
Contributor

ah, gotcha, sorry for the confusion.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chewong chewong merged commit 108bd09 into master Apr 25, 2022
@chewong chewong deleted the release-v3.9.0-beta.0 branch April 25, 2022 18:22
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Jul 19, 2022
Co-authored-by: Ernest Wong <chuwon@microsoft.com>
Signed-off-by: davis-haba <davishaba@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants