feat: Allow wildcard at start string and end together #2130

erezo9 · 2022-06-29T04:32:03Z

What this PR does / why we need it:
add support for wild card at the end and start of a namespace
for example -dev-

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #2128

Special notes for your reviewer:
With the help of @maxsmythe was able to complete the PR

codecov-commenter · 2022-06-29T04:38:35Z

Codecov Report

Merging #2130 (3cfa568) into master (92b3b7d) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
- Coverage   54.38%   54.30%   -0.09%     
==========================================
  Files         111      111              
  Lines        9478     9504      +26     
==========================================
+ Hits         5155     5161       +6     
- Misses       3933     3946      +13     
- Partials      390      397       +7

Flag	Coverage Δ
unittests	`54.30% <100.00%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/target/match_schema.go	`100.00% <ø> (ø)`
pkg/util/wildcard.go	`100.00% <100.00%> (ø)`
pkg/gator/runner.go	`87.44% <0.00%> (-9.42%)`	⬇️
pkg/readiness/object_tracker.go	`82.91% <0.00%> (-1.07%)`	⬇️
...onstrainttemplate/constrainttemplate_controller.go	`55.87% <0.00%> (+0.95%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b3b7d...3cfa568. Read the comment docs.

maxsmythe · 2022-06-29T04:41:13Z

Looks like lint is failing... running gofmt -s -w against the files should fix that

pkg/util/wildcard_test.go

chewong

Can you revert the changes in charts/ folder? They should not be reflected in charts/ since that folder is reserved for versioned charts only.

erezo9 · 2022-06-29T16:42:48Z

also for the deploy folder? which has the manifest?

maxsmythe · 2022-06-29T19:52:43Z

yep, for deploy folder as well

maxsmythe · 2022-06-29T19:54:51Z

pkg/util/wildcard_test.go

+			matches:   false,
+		},
+		{
+			name:      "wild card at suffix and prefix, multiple hyphens",


can we have a double-wildcard and no match, just to make sure that code path gets tested?

maxsmythe

LGTM, thank you for the PR!

ritazh

LGTM

Signed-off-by: Erez Tamam <erezo9@gmail.com>

…ent#2130) * Change all roles to support extra rules Signed-off-by: Erez Tamam <erezo9@gmail.com> * add astrix on start and end Signed-off-by: Erez Tamam <erezo9@gmail.com> * add check of wild card, for both prefix and suffix Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove rules from this pr Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove new line Signed-off-by: Erez Tamam <erezo9@gmail.com> * lint files Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test, fix misspelling Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test for mutltiple hyphens Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove change deploy and charts Signed-off-by: Erez Tamam <erezo9@gmail.com> * add 2 more tests Signed-off-by: Erez Tamam <erezo9@gmail.com> * change test name Signed-off-by: Erez Tamam <erezo9@gmail.com> Signed-off-by: Christoph Fraundorfer <christoph.fraundorfer@allianzdirect.de>

…ent#2130) * Change all roles to support extra rules Signed-off-by: Erez Tamam <erezo9@gmail.com> * add astrix on start and end Signed-off-by: Erez Tamam <erezo9@gmail.com> * add check of wild card, for both prefix and suffix Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove rules from this pr Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove new line Signed-off-by: Erez Tamam <erezo9@gmail.com> * lint files Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test, fix misspelling Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test for mutltiple hyphens Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove change deploy and charts Signed-off-by: Erez Tamam <erezo9@gmail.com> * add 2 more tests Signed-off-by: Erez Tamam <erezo9@gmail.com> * change test name Signed-off-by: Erez Tamam <erezo9@gmail.com>

…ent#2130) * Change all roles to support extra rules Signed-off-by: Erez Tamam <erezo9@gmail.com> * add astrix on start and end Signed-off-by: Erez Tamam <erezo9@gmail.com> * add check of wild card, for both prefix and suffix Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove rules from this pr Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove new line Signed-off-by: Erez Tamam <erezo9@gmail.com> * lint files Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test, fix misspelling Signed-off-by: Erez Tamam <erezo9@gmail.com> * add test for mutltiple hyphens Signed-off-by: Erez Tamam <erezo9@gmail.com> * remove change deploy and charts Signed-off-by: Erez Tamam <erezo9@gmail.com> * add 2 more tests Signed-off-by: Erez Tamam <erezo9@gmail.com> * change test name Signed-off-by: Erez Tamam <erezo9@gmail.com> Signed-off-by: davis-haba <davishaba@google.com>

erezo9 changed the title ~~Allow wildcard at start string~~ feat: Allow wildcard at start string and end together Jun 29, 2022

maxsmythe requested changes Jun 29, 2022

View reviewed changes

pkg/util/wildcard_test.go Outdated Show resolved Hide resolved

pkg/util/wildcard_test.go Outdated Show resolved Hide resolved

erezo9 requested a review from maxsmythe June 29, 2022 05:16

chewong requested changes Jun 29, 2022

View reviewed changes

erezo9 force-pushed the allow-wildcard-at-start-string branch from 4c6ad81 to 569bb16 Compare June 29, 2022 16:55

erezo9 requested a review from chewong June 29, 2022 16:58

maxsmythe reviewed Jun 29, 2022

View reviewed changes

sozercan added this to the v3.9.0 milestone Jun 29, 2022

maxsmythe approved these changes Jun 30, 2022

View reviewed changes

chewong force-pushed the allow-wildcard-at-start-string branch from 3cfa568 to 169e785 Compare June 30, 2022 05:06

ritazh approved these changes Jun 30, 2022

View reviewed changes

erezo9 added 11 commits June 30, 2022 08:59

Change all roles to support extra rules

19a5fa8

Signed-off-by: Erez Tamam <erezo9@gmail.com>

add astrix on start and end

3cf4d36

Signed-off-by: Erez Tamam <erezo9@gmail.com>

add check of wild card, for both prefix and suffix

192b125

Signed-off-by: Erez Tamam <erezo9@gmail.com>

remove rules from this pr

4c6aa52

Signed-off-by: Erez Tamam <erezo9@gmail.com>

remove new line

39ba413

Signed-off-by: Erez Tamam <erezo9@gmail.com>

lint files

9779d13

Signed-off-by: Erez Tamam <erezo9@gmail.com>

add test, fix misspelling

e666af4

Signed-off-by: Erez Tamam <erezo9@gmail.com>

add test for mutltiple hyphens

bee2908

Signed-off-by: Erez Tamam <erezo9@gmail.com>

remove change deploy and charts

a66261d

Signed-off-by: Erez Tamam <erezo9@gmail.com>

add 2 more tests

ffaad99

Signed-off-by: Erez Tamam <erezo9@gmail.com>

change test name

17d3f61

Signed-off-by: Erez Tamam <erezo9@gmail.com>

chewong force-pushed the allow-wildcard-at-start-string branch from 169e785 to 17d3f61 Compare June 30, 2022 15:59

chewong approved these changes Jun 30, 2022

View reviewed changes

chewong merged commit 92ccd80 into open-policy-agent:master Jun 30, 2022

eyenx mentioned this pull request Oct 4, 2022

chore(gatekeeper): update to 3.9.* adfinis/helm-charts#824

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Allow wildcard at start string and end together #2130

feat: Allow wildcard at start string and end together #2130

erezo9 commented Jun 29, 2022

codecov-commenter commented Jun 29, 2022 •

edited

Loading

maxsmythe commented Jun 29, 2022

chewong left a comment

erezo9 commented Jun 29, 2022

maxsmythe commented Jun 29, 2022

maxsmythe Jun 29, 2022

maxsmythe left a comment

ritazh left a comment

feat: Allow wildcard at start string and end together #2130

feat: Allow wildcard at start string and end together #2130

Conversation

erezo9 commented Jun 29, 2022

codecov-commenter commented Jun 29, 2022 • edited Loading

Codecov Report

maxsmythe commented Jun 29, 2022

chewong left a comment

Choose a reason for hiding this comment

erezo9 commented Jun 29, 2022

maxsmythe commented Jun 29, 2022

maxsmythe Jun 29, 2022

Choose a reason for hiding this comment

maxsmythe left a comment

Choose a reason for hiding this comment

ritazh left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 29, 2022 •

edited

Loading