Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): unify and extend hook job pod labels #2205

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

stek29
Copy link
Contributor

@stek29 stek29 commented Jul 29, 2022

What this PR does / why we need it:
It unifies all of the hook jobs to have same labels, and to have them both on Job and Pod being created by it.

Which issue(s) this PR fixes:
Fixes #2204

@stek29 stek29 force-pushed the helmlabels branch 5 times, most recently from 601aab5 to 4a8fe16 Compare August 2, 2022 19:01
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm: pods created by hook jobs are missing necessary labels
3 participants