Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update audit duration buckets #2234

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

stek29
Copy link
Contributor

@stek29 stek29 commented Aug 21, 2022

What this PR does / why we need it:
Updates Audit Duration metric (audit_duration_seconds) with longer time period buckets.
See #2197 for more info.

@stek29 stek29 changed the title chore: update audit duration buckets (see #2197) chore: update audit duration buckets Aug 21, 2022
@stek29
Copy link
Contributor Author

stek29 commented Aug 21, 2022

I don't think that test failure has anything to do with my changes, I'll try to push a reworded commit to trigger new run.

See open-policy-agent#2197

Signed-off-by: Viktor Oreshkin <imselfish@stek29.rocks>
@codecov-commenter
Copy link

Codecov Report

Merging #2234 (485ef47) into master (8f6d95a) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
+ Coverage   54.34%   54.46%   +0.12%     
==========================================
  Files         111      111              
  Lines        9538     9538              
==========================================
+ Hits         5183     5195      +12     
+ Misses       3954     3946       -8     
+ Partials      401      397       -4     
Flag Coverage Δ
unittests 54.46% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/audit/stats_reporter.go 77.55% <100.00%> (ø)
pkg/controller/config/config_controller.go 64.10% <0.00%> (ø)
...onstrainttemplate/constrainttemplate_controller.go 58.03% <0.00%> (+1.91%) ⬆️
pkg/readiness/list.go 91.17% <0.00%> (+11.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @stek29!

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 368961a into open-policy-agent:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants