-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add metric reporting to ExpansionTemplate controller #2276
feat: Add metric reporting to ExpansionTemplate controller #2276
Conversation
Signed-off-by: davis-haba <davishaba@google.com>
Codecov ReportBase: 53.36% // Head: 53.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2276 +/- ##
==========================================
- Coverage 53.36% 53.35% -0.01%
==========================================
Files 116 116
Lines 10161 10161
==========================================
- Hits 5422 5421 -1
- Misses 4319 4320 +1
Partials 420 420
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this!
Signed-off-by: davis-haba <davishaba@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: davis-haba davishaba@google.com
What this PR does / why we need it:
Adds metric reporting to the ExpansionTemplate Controller. The controller will simply report a count of the number of ExpansionTemplates on the cluster.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: