feat: Add controllerManager tlsMinVersion option to values #2289
Conversation
Signed-off-by: Grace Do <xgrace@gmail.com>
| @@ -91,6 +91,7 @@ spec: | |||
| - HELMSUBST_DEPLOYMENT_CONTROLLER_MANAGER_DISABLED_BUILTIN | |||
| - HELMSUBST_DEPLOYMENT_CONTROLLER_MANAGER_EXEMPT_NAMESPACES | |||
| - HELMSUBST_DEPLOYMENT_CONTROLLER_MANAGER_EXEMPT_NAMESPACE_PREFIXES | |||
| - HELMSUBST_DEPLOYMENT_CONTROLLER_MANAGER_EXTRA_ARGS | |||
There was a problem hiding this comment.
Thanks for the PR @gracedo!
In this case, I think it's more readable and debuggable if we explicitly have a helm values field to set the tls-min-version flag instead of a generic arg field.
There was a problem hiding this comment.
@ritazh Thanks for reviewing! I will add a field for tls-min-version - but I think keeping the extraArgs might still be useful in general and keep things flexible, wdyt? Otherwise, maybe we should explicitly add an option for all the possible flags that can be passed into the controller manager?
There was a problem hiding this comment.
so far we have been explicitly creating fields for each flag so that by enabling a field, you are enabling the feature and its related resources can all be conditionally added/removed.
This reverts commit 7257903. Signed-off-by: Grace Do <xgrace@gmail.com>
Signed-off-by: Grace Do <xgrace@gmail.com>
gracedo
changed the title
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com> Signed-off-by: Grace Do <xgrace@gmail.com>
Codecov ReportBase: 53.33% // Head: 53.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2289 +/- ##
==========================================
+ Coverage 53.33% 53.41% +0.08%
==========================================
Files 116 116
Lines 10161 10161
==========================================
+ Hits 5419 5428 +9
+ Misses 4321 4315 -6
+ Partials 421 418 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Grace Do <xgrace@gmail.com>
Signed-off-by: Grace Do xgrace@gmail.com
What this PR does / why we need it:
Add option to pass in extra arguments to the controller manager. This allows a user to, for example, pass in the--tls-min-versionflag to override the default value.Add
tlsMinVersionvalues field to allow user to override the default value of the--tls-min-versionflag (which is set to1.3)Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #2288
Special notes for your reviewer: