Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding pubsub interface #2538
feat: Adding pubsub interface #2538
Changes from 20 commits
acec1fe
c91fcb9
2d795e8
4da87c6
ce86992
fb3a791
21f3ccd
cced7f7
4a557d5
2581824
2ac3adc
20010f0
e8793e4
e9a1559
f8a60f6
f3ddfb9
76af8d0
9be106a
561839a
17e0271
2cf8b7c
6bf81ca
43acf63
a09ff0e
1319b9e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we added this to .tmp, do we still need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted that change back, since creating
annotation.yaml
in.tmp
was causing CI to error out withcannot create /.tmp/annotations.yaml: Directory nonexistent
msg.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the directory nonexistent? Is there a way to remedy this?
It would be good to avoid clutter in the root directory: saying "
rm -rf <temp directory>
will recover if we have any bad state" is a lot easier than saying "delete these X files"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump (was not addressed since last review request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I addressed it. Creating a tmp dir while bootstrapping to mitigate
dir nonexistent
error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!