Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: the linter structcheck varcheck and deadcode are deprecated (since v1.49.0) #2550

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

Fish-pro
Copy link
Contributor

… abandoned the linter. Replaced by unused.

Signed-off-by: Fish-pro zechun.chen@daocloud.io

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

… abandoned the linter. Replaced by unused.

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Base: 53.41% // Head: 53.44% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ef34a79) compared to base (5ab923e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
+ Coverage   53.41%   53.44%   +0.02%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
+ Hits         5680     5683       +3     
+ Misses       4516     4514       -2     
+ Partials      438      437       -1     
Flag Coverage Δ
unittests 53.44% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onstrainttemplate/constrainttemplate_controller.go 55.50% <0.00%> (-0.24%) ⬇️
pkg/watch/replay.go 81.25% <0.00%> (+2.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@sozercan sozercan merged commit 431db17 into open-policy-agent:master Jan 31, 2023
maxsmythe pushed a commit to maxsmythe/gatekeeper that referenced this pull request Feb 7, 2023
…ted (since v1.49.0) (open-policy-agent#2550)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
…ted (since v1.49.0) (open-policy-agent#2550)

Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants