Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add assignImage mutation demo #2694

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

ritazh
Copy link
Member

@ritazh ritazh commented Apr 12, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Copy link
Contributor

@acpana acpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we going to add an interactive shell like for basic or just the .yaml? If it's the latter, I'm curious if those would be better on the website?

@ritazh
Copy link
Member Author

ritazh commented Apr 22, 2023

Were we going to add an interactive shell like for basic or just the .yaml? If it's the latter, I'm curious if those would be better on the website?

We currently have https://open-policy-agent.github.io/gatekeeper/website/docs/mutation#assignimage in the website. NOTE: The sample yaml shown is not the same as the "replace for all in a mirror" scenario I used in the Kubecon talk, which IMO is more close to how users will use this feature. I can update the yaml in the website if that makes more sense.

In terms of adding this to the interactive shell demo, we currently do not have anything for mutation in the demo. I can add to it if folks think we should or I can just add this to the website. WDYT?

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay.

@ritazh ritazh merged commit 5e83d3f into open-policy-agent:master Apr 28, 2023
@ritazh ritazh deleted the demo-assignimage branch April 28, 2023 12:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants