Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cert-controller #2876

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Jul 13, 2023

bumps cert controller to include open-policy-agent/cert-controller#81

That should fix #2477 .

Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana
Copy link
Contributor Author

acpana commented Jul 13, 2023

license lint failing per #2854 but there shouldn't be any licensing issues

@ritazh ritazh modified the milestones: v3.14.0, v3.13.0 Jul 13, 2023
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana acpana requested a review from sozercan July 13, 2023 22:34
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (6b315d2) 53.55% compared to head (c8b17bb) 53.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
- Coverage   53.55%   53.54%   -0.01%     
==========================================
  Files         133      133              
  Lines       11545    11545              
==========================================
- Hits         6183     6182       -1     
- Misses       4885     4886       +1     
  Partials      477      477              
Flag Coverage Δ
unittests 53.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 9482ee0 into open-policy-agent:master Jul 14, 2023
14 of 15 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certwatcher issue
4 participants