Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ns exclusion audit from cache #3129

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix: ns exclusion audit from cache #3129

merged 4 commits into from
Oct 31, 2023

Conversation

acpana
Copy link
Contributor

@acpana acpana commented Oct 30, 2023

fixes #3112

@acpana
fix: ns exclusion audit from cache
9d30811 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana acpana requested a review from a team as a code owner October 30, 2023 21:06
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (40f15ef) 52.66% compared to head (680a4ab) 53.11%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3129      +/-   ##
==========================================
+ Coverage   52.66%   53.11%   +0.44%     
==========================================
  Files         134      134              
  Lines       11890    11897       +7     
==========================================
+ Hits         6262     6319      +57     
+ Misses       5141     5083      -58     
- Partials      487      495       +8
Flag Coverage Δ
unittests 53.11% <57.14%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/audit/manager.go 13.95% <57.14%> (+4.11%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maxsmythe
maxsmythe approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after nit fix

pkg/fakes/fixtures.go Outdated Show resolved Hide resolved
@acpana
ConstraintFor
f8450c5 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@acpana
Merge branch 'master' into acpana/fix-ns-exclusion
680a4ab 
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
sozercan
sozercan approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! LGTM

@sozercan
Merge branch 'master' into acpana/fix-ns-exclusion
d8b18dd 
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
@acpana acpana merged commit 384150f into open-policy-agent:master Oct 31, 2023
16 checks passed
@ritazh
Copy link
Member

ritazh commented Oct 31, 2023

Should we cherry pick this to earlier supported GK releases?

@maxsmythe
Copy link
Contributor

No objections.

acpana added a commit to acpana/gatekeeper that referenced this pull request Nov 1, 2023
@acpana @sozercan
fix: ns exclusion audit from cache (open-policy-agent#3129)
143ea93 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
@acpana acpana mentioned this pull request Nov 1, 2023
Merged
acpana added a commit to acpana/gatekeeper that referenced this pull request Nov 1, 2023
@acpana @sozercan
fix: ns exclusion audit from cache (open-policy-agent#3129)
2ccd4af 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
sozercan added a commit that referenced this pull request Nov 1, 2023
@acpana @sozercan
fix: ns exclusion audit from cache (#3129) cherry-pick for 3.14 (#3141)
3b9f645 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
sozercan added a commit that referenced this pull request Nov 2, 2023
@acpana @sozercan
fix: ns exclusion audit from cache (#3129) cherry-pick for 3.13 (#3140)
72364ad 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
acpana added a commit to acpana/gatekeeper that referenced this pull request Nov 16, 2023
@acpana @sozercan
fix: ns exclusion audit from cache (open-policy-agent#3129)
e518953 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
dhaiducek added a commit to dhaiducek/gatekeeper that referenced this pull request Feb 20, 2024
@dhaiducek @sozercan
fix: ns exclusion audit from cache (open-policy-agent#3129)
d4bf5c5 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek added a commit to dhaiducek/gatekeeper that referenced this pull request Feb 20, 2024
@dhaiducek @sozercan
fix: ns exclusion audit from cache (open-policy-agent#3129)
bba9405 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
openshift-merge-bot bot pushed a commit to stolostron/gatekeeper that referenced this pull request Feb 20, 2024
@dhaiducek @sozercan @openshift-merge-bot
fix: ns exclusion audit from cache (open-policy-agent#3129)
2a591fb 
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Signed-off-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Co-authored-by: Sertaç Özercan <852750+sozercan@users.noreply.github.com>
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

@maxsmythe maxsmythe maxsmythe approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gatekeeper Audit not ignoring excluded namespaces
5 participants
@acpana @codecov-commenter @ritazh @maxsmythe @sozercan