Use patch to set finalizers #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
patch-finalizers
branch
from
e5ce293
to
aa596b4
Compare
|
No objections to changing this to patch. I'm curious why you think gatekeeper would change the deletion timestamp? Gatekeeper does not modify those. I do see this bit of information WRT deletion timestamps and pods, unsure if it's relevant: |
maxsmythe
approved these changes
Dec 2, 2019
Just a guess. Something pretty strange is going on! |
|
@maxsmythe are there integration tests which explicitly test for finalizer removal? |
ritazh
reviewed
Dec 3, 2019
|
Yep, the config controller tests look for sync finalizer removal: |
|
Would be nice to add a test for sync finalizer removal in e2e, similar to here: https://github.com/open-policy-agent/gatekeeper/blob/master/test/bats/test.bats#L82 |
|
@ritazh Is this blocking for you? |
|
no. I have created #323 to track. |
For pods in terminating state, their deletion timestamp is constantly increasing, I'm not sure why but I suspect its do to with gatekeeper. As a result, their resource version increases. This means that when we try to remove the finalizer, there is an error 'this object has already changed'. I think that using a patch will fix this. Signed-off-by: Jack Kleeman <jackkleeman@gmail.com>
jackkleeman
force-pushed
the
patch-finalizers
branch
from
aa596b4
to
0b1e14a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pods in terminating state, their deletion timestamp is constantly
increasing, I'm not sure why but I suspect its do to with gatekeeper. As
a result, their resource version increases. This means that when we try
to remove the finalizer, there is an error 'this object has already
changed'. I think that using a patch will fix this.