-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add request input struct #3234
docs: add request input struct #3234
Conversation
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
@@ -138,16 +138,4 @@ kubectl get constraints | |||
``` | |||
|
|||
### Input Review | |||
|
|||
The `input.review` object stores the [admission request](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/admission#AdmissionRequest) under evaluation. It has the following fields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is updated same as the other one. For whatever reason the display is showing the new line below the deleted bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Xander Grzywinski <xandergrzyw@gmail.com>
What this PR does / why we need it: Part of the docs requested in #66. Gives users documentation on the structure of admission requests.