-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: pointing to correct versioned yaml on website creation #3258
ci: pointing to correct versioned yaml on website creation #3258
Conversation
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3258 +/- ##
==========================================
- Coverage 54.28% 54.14% -0.15%
==========================================
Files 134 134
Lines 12356 10253 -2103
==========================================
- Hits 6707 5551 -1156
+ Misses 5152 4196 -956
- Partials 497 506 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit bfaca20)
@ritazh @maxsmythe @sozercan This change sould now handle patching docs for subsequent minor release patches as well. |
.github/workflows/patch-docs.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to avoid a second pr? why can't we do this in the same pr for the beta release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the beta PR only gets released on a new minor version release, and docs changes are included with that. However, the patch-doc workflow is specifically for subsequent patch versions for which we do not update beta.
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@sozercan are we good to merge this? |
…cy-agent#3258) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
What this PR does / why we need it:
Correctly updates the install command to point to appropriate versions in website.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: