-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove validation of constraint template rego #3262
fix: Remove validation of constraint template rego #3262
Conversation
Signed-off-by: Mohammad Zuber Khan <khan.zuber@gmail.com>
ba2304f
to
43f33c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3262 +/- ##
==========================================
+ Coverage 54.49% 54.52% +0.02%
==========================================
Files 134 134
Lines 12329 12318 -11
==========================================
- Hits 6719 6716 -3
+ Misses 5117 5107 -10
- Partials 493 495 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mzkhan can you fix the linting error? the change looks good to me. |
Minor comment, otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after sozercan's comment and lint errors are addressed.
Thank you for the contribution!
Signed-off-by: Mohammad Zuber Khan <khan.zuber@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM
…#3262) Signed-off-by: Mohammad Zuber Khan <khan.zuber@gmail.com>
What this PR does / why we need it:
Removing the flag to validate rego in constraint template.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #3027