-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: bump k8s matrix #3267
ci: bump k8s matrix #3267
Conversation
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3267 +/- ##
==========================================
+ Coverage 54.46% 54.50% +0.04%
==========================================
Files 134 134
Lines 12318 12318
==========================================
+ Hits 6709 6714 +5
+ Misses 5113 5109 -4
+ Partials 496 495 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming flaky test passes?
Looks like the breakage may not be a flake:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
un-LGTMing until we know what's needed to fix the test
yea this needs further investigation |
d9137d7
to
3b1cc4a
Compare
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
3b1cc4a
to
c98b6f9
Compare
df7294c
to
ff4d6ab
Compare
@maxsmythe updated. there was a change in k8s 1.29 to require certain types for externalIPs kubernetes/kubernetes#119150 |
Good find! Kinda weird that not defining that results in a stack trace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sertac Ozercan <sozercan@gmail.com>
What this PR does / why we need it:
drops eol 1.25, adds 1.29
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: